Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the symbol Visibility enum #134261

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Document the symbol Visibility enum #134261

merged 1 commit into from
Dec 14, 2024

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Dec 13, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2024
@bjorn3
Copy link
Member Author

bjorn3 commented Dec 13, 2024

cc @folkertdev

@bjorn3 bjorn3 mentioned this pull request Dec 13, 2024
Open
lqd
lqd approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit, and removing the apostrophes from "DSO's"

@bjorn3 bjorn3 force-pushed the document_symbol_visibility branch from 9f19c28 to af3721e Compare December 13, 2024 19:14
@bjorn3
Copy link
Member Author

bjorn3 commented Dec 13, 2024

@bors r=lqd rollup=always

@bors
Copy link
Contributor

bors commented Dec 13, 2024

📌 Commit af3721e has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2024
This was referenced Dec 14, 2024
Closed
Merged
@bors bors merged commit cb459fa into rust-lang:master Dec 14, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 14, 2024
@bjorn3 bjorn3 deleted the document_symbol_visibility branch December 14, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd approved these changes

Assignees

@nnethercote nnethercote

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bjorn3 @rustbot @bors @lqd @nnethercote